AUR (en) – spotdl

@pekkarr thanks a lot for the help

files.pythonhosted.org is just an alternative URL for downloading PyPI sdists. The files are exactly the same as those downloaded from pypi.io. The Python package guidelines list those URLs, but there’s a “Note: With RFC0020 the default is to use upstream provided source tarballs, instead of PyPI provided sdist tarballs”. So getting the source from Github would be better (with renaming the source file as in the previous comment).

Another minor issue is that $pkgname should not be in provides, as every package implicitly provides itself.

Otherwise the spotdl package looks good.

@zoorat Thanks! Could you also prefix the source tarball with $pkgname as @gesh suggested? Arch package guidelines say that sources have to be unique. The PKGBUILD wiki page explains why this is needed. For example, the source variable could be defined as

source=("$pkgname-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz")

@pekkarr i didn’t know about this pypi situation. i am updating it now.

@zoorat Please don’t use PyPI as the source, see Arch Linux RFC 20. And yes, upstream changed the v4.2.5 git tag from c646615 to bd38845 which is why the checksum changed.

By the way, I agree with @xiota, this package should be renamed to spotdl. This could be done by submitting it with the new name to AUR and then submitting a merge request to merge python-spotdl into spotdl.

@gesh thanks for the report

the reason why the b2sum is wrong is because they published v4.2.5 twice. (just checked my emails)
most probably because they had some build error before. i am updating it now.

and all tarballs you tested failed because i changed the source from pypi.io to github for upgrading to the 4.2.5 version.

b2sums incorrectly updated, and it is unclear what release it was generated from — testing with the tarballs for 4.2.{3,4,5} all yield different b2sums.

Also, please prefix the source tarball with $pkgname — some of us combine source caches, and it is nice to have some indication of what package pulled in what source.

This package should be renamed to spotdl. The current name makes it look like a python library.

I agree with @pekkarr about Makefile, let’s keep things simple.

I use a bash script for myself for bumping packages which it’s local and github.com/aminvakil/aur to test changes and build packages nightly for packages I maintain and co-maintain (which I invite you to use in case you wanted a really clean build and / or propose changes or good to haves in it).

Also aurpublish, locally and on github actions.